Fix incompatible attribute #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry rebase issue, please hold... |
astrofrog
force-pushed
the
fix-incompatible-attribute
branch
from
25b75b4 to
8f32b5d
Compare
9 tasks
|
This is ready for review by the way (the rebase has been fixed) |
pllim
reviewed
Aug 24, 2021
| try: | ||
| layer_data = handler.to_object(layer_data, | ||
| statistic=statistic) | ||
| except IncompatibleAttribute: |
There was a problem hiding this comment.
Looks awfully similar to glue-viz/glue-astronomy#39 but I think we're patching different things?
There was a problem hiding this comment.
Ah yes it does seem like the same thing. I think we do want to handle things better in glue-astronomy but I think we still want to raise an error there rather than silently fail, and we do want to catch those exceptions here.
There was a problem hiding this comment.
So I would suggest we go ahead with this PR, modify the glue-astronomy one to raise a better exception, and then update the exception we catch in jdaviz once glue-astronomy is released.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsets that can't be computed for a given dataset shouldn't be converted to e.g. Spectrum1D and so on.